Need tips to optimize SQL Server stored procedure -

-

this stored procedure, it's taking time execute though running local database.

please suggest changes in order improve performance 

begin try         declare @country_cd int         set @country_cd =(select country_cd country country_desc = ltrim(rtrim(@country_desc)))         declare @companny_cd int         set @companny_cd =(select company_cd company company_desc = ltrim(rtrim(@company_desc)))     begin transaction         delete pack            country_cd = @country_cd                  , company_cd = @companny_cd                 , pack_desc = ltrim(rtrim(@pack_desc))     commit transaction end try begin catch     if(@@trancount > 0)         rollback transaction     declare @errmsg nvarchar(4000),              @errseverity int     select @errmsg = error_message(),@errseverity = error_severity()     raiserror(@errmsg, @errseverity, 1) end catch

hard without knowing more database schema. few initial ideas might cleanup *_desc variables right away rather doing ltrim , rtrim in clause. maybe consider or add index on pack table includes country_cd/company_cd (not description though, assuming it's long string text. think company , country pretty small tables, have proper indexes on fields. might worth trying join tables in delete rather doing lookups ahead of time.

-- clenaup variables -- these should new vars, not input parms select @country_desc = ltrim(rtrim(@country_desc))     ,@company_desc = ltrim(rtrim(@company_desc))     ,pack_desc = ltrim(rtrim(@pack_desc ))  -- delete    delete pack pack join country on pack.country_cd = country.country_cd join company on pack.company_cd = company.company_cd   country.country_desc = @country_desc  , company.company_desc = @company_desc , pack.pack_desc = @pack_desc

Comments

Post a Comment

Popular posts from this blog

c++ - Creating new partition disk winapi -

-
i'am trying create new partition , mount volume new, thought createfile let me this, code : lpctstr lpfilename=l"\\\\.\\device\\harddisk0\\partition3"; handle handl=createfile( lpfilename, generic_read | generic_write, file_share_read | file_share_write, null, create_always, file_attribute_normal, null ); if (handl==invalid_handle_value) { qdebug()<<"handl invalid"<<" error"<<getlasterror();} bool success = definedosdevice(ddd_raw_target_path,l"i:",l"\\device\\harddisk0\\partition3"); if(!success) qdebug()<<" definedosdevice failed "<<getlasterror(); bflag = getvolumenameforvolumemountpoint( l"i:\\", // input volume mount point or directory /** u in dir
Read more

Android Prevent Bluetooth Pairing Dialog -

-
i'm developing internal application uses bluetooth printing. want bluetooth pairing occur without user input. have managed working trapping android.bluetooth.device.action.pairing_request broadcast. in broadcast receiver call setpin method, , pairing works ok, bluetoothpairingdialog displayed second or two, disappears - see link below. https://github.com/android/platform_packages_apps_settings/blob/master/src/com/android/settings/bluetooth/bluetoothpairingdialog.java since broadcast non-ordered, can't call abortbroadcast() , , wondering if there other way prevent pairing dialog appearing. can hook window manager in way? i haven't been able come way without modifying sdk. if you're oem, it's easy (i'm on 4.3): in packages/apps/settings/androidmanifest.xml, comment intent filter pairing dialog: <activity android:name=".bluetooth.bluetoothpairingdialog" android:label="@string/bluetooth_pairing_request"
Read more

VBA function to include CDATA -

-
i have following function include cdata: function cdatasection() dim objdom domdocument dim objkmlrootelement ikmldomelement dim objkmlelement ikmldomelement dim cdata ikmldomcdatasection set objdom = new domdocument set objkmlrootelement = objdom.createelement("balloonstyle") objdom.appendchild objkmlrootelement set objkmlelement = objdom.createelement("text") objkmlrootelement.appendchild objkmlelement set cdata = objdom.createcdatasection("text") cdata.data = "<![cdata[<b>latitude = $[latitude]</b>?]]>;" end function when run above, getting error "user defined data type not found" function. yes ripster says find library reference. vba window tools>references for list of relevant references see... http://msdn.microsoft.com/en-us/library/windows/desktop/ms763701%28v=vs.85%29.aspx however, if have hard time tracking down reference, replace dim sta
Read more